Skip to content

feat: magic rollback #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

feat: magic rollback #135

wants to merge 13 commits into from

Conversation

itslychee
Copy link
Member

No description provided.

@github-actions github-actions bot added rust Pull requests that update rust code nix Pull requests that update nix. release PRs against main labels Apr 18, 2025
@itslychee
rename all references of key_agent to agent for consistency
6e11939 
Unifying the key agent with the magic rollback feature soon to be implemented
@itslychee itslychee force-pushed the itslychee/magic-rollback branch from 8dd711f to 6e11939 Compare April 19, 2025 00:34
@itslychee itslychee linked an issue Apr 19, 2025 that may be closed by this pull request
magic rollback #32
Open
@itslychee
hive.inspect: add hostPlatform to inspect
365d68d 
This will be used for the agent to correctly determine what binary to push.
@mrshmllow @itslychee
Default on Node only for tests
21eafe3 
(cherry picked from commit 6867407)
@itslychee
agent: support multiple architectures
7d9cb7c 
Preload `wire` with the supported architectures and it will copy its arch-specific
agent store path to the nodes.
@itslychee itslychee force-pushed the itslychee/magic-rollback branch from e0087b6 to 7d9cb7c Compare April 20, 2025 05:51
@github-actions github-actions bot added github_actions Pull requests that update GitHub Actions code github / ci / meta labels Apr 20, 2025
@itslychee itslychee force-pushed the itslychee/magic-rollback branch from 306d65e to 9dbd1a3 Compare April 20, 2025 06:05
@itslychee itslychee force-pushed the itslychee/magic-rollback branch from 9dbd1a3 to 381b6ec Compare April 20, 2025 08:03
@itslychee
Copy link
Member Author

things that should be implemented in this PR:

  • Baseline magic rollback functionality
  • A good UI/UX surrounding it's use
  • Allow wire to recover from unexpected terminations during a deployment to prevent undesirable rollbacks
  • have progress bar for the grace period/timeout countdowns
  • add documentation

@itslychee
initial magic rollback framework
41503d7 
* proto buffers soon to be added
* unix listener soon to be implemented
@itslychee itslychee closed this May 5, 2025
@itslychee itslychee reopened this May 6, 2025
@itslychee itslychee force-pushed the itslychee/magic-rollback branch from 0866790 to d207a8c Compare June 3, 2025 14:12
@itslychee itslychee force-pushed the itslychee/magic-rollback branch from d207a8c to 954732e Compare June 3, 2025 14:15
@itslychee itslychee force-pushed the itslychee/magic-rollback branch from 954732e to de20788 Compare June 3, 2025 14:18
@itslychee itslychee force-pushed the itslychee/magic-rollback branch from de20788 to 79d6fc3 Compare June 3, 2025 14:20
@itslychee itslychee force-pushed the itslychee/magic-rollback branch from 79d6fc3 to b312888 Compare June 3, 2025 14:24
@itslychee itslychee force-pushed the itslychee/magic-rollback branch from 36e52fa to 566de63 Compare June 3, 2025 17:08
@itslychee itslychee force-pushed the itslychee/magic-rollback branch from 566de63 to 30a2f27 Compare June 3, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrshmllow mrshmllow Awaiting requested review from mrshmllow mrshmllow will be requested when the pull request is marked ready for review mrshmllow is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code github / ci / meta nix Pull requests that update nix. release PRs against main rust Pull requests that update rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

magic rollback
2 participants
@itslychee @mrshmllow